Added JFR Event Streaming Demo#347
Conversation
There was a problem hiding this comment.
Hi @NayanKaushik25 and thank you for your contribution.
Unfortunatelly, like this it cannot be accepted, because the new demo file won't get loaded in src/main/java/org/javademos/init/Java14DemoLoader.java and the info method won't find required data for JEP 349 in src/main/resources/JDK14Info.json.
Please, check the recent PRs or refer to the contribution guide, and update your PR accordingly, so it can be accepted and merged
AloisSeckar
added
the
changes requested
|
@AloisSeckar I made the changes. Please take a look. |
…antiated the demo
| import org.javademos.java14.jep366.ParallelScavengeGCCombinationDemo; | ||
| import org.javademos.java14.jep368.TextBlockSecondPreviewDemo; | ||
| import org.javademos.java14.jep370.ForeignMemoryAccessDemo; | ||
| import org.javademos.java14.jep349.JFREventStreamingDemo; |
There was a problem hiding this comment.
Thank you for updates. To keep the consistency across the project, please also re-arrange the import to be ordered by the JEP number (so it would appear at line 10)
| demos.put(366, new ParallelScavengeGCCombinationDemo()); | ||
| demos.put(368, new TextBlockSecondPreviewDemo()); | ||
| demos.put(370, new ForeignMemoryAccessDemo()); | ||
| demos.put(349, new JFREventStreamingDemo()); |
There was a problem hiding this comment.
same here, please maintain the order by the number ascending
src/main/resources/JDK14Info.json
Outdated
| "link": true, | ||
| "code": false | ||
| }, | ||
| { |
There was a problem hiding this comment.
and also here in the JSON file - records should be ordered to be able to navigate through them quickly
…ile and the DemoLoader file
|
Ok. I reordered them. |
@NayanKaushik25 the import is still on line 19 - should be also moved to line 10 |
AloisSeckar
added
hacktoberfest
|
My apologies. I've reordered it now. |
2 participants
Solves Issue #327 by implementing a demo for JFR Event Streaming.
Features Implemented: